Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to standalone plugin SDK #35

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Mar 2, 2020

Migrate to the standalone Terraform plugin SDK Go module as described in https://www.terraform.io/docs/extend/plugin-sdk.html.

@kmoe kmoe requested a review from a team March 2, 2020 18:31
)

go 1.13
Copy link
Contributor

@appilon appilon Mar 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to bump the version of go in .go-version. Regret ever encoding that file across all the providers.... it does play an important role on TeamCity though for both tests and releases.

If the mod file has 1.13 encoded lets make sure travis is bumped to 1.13

Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump .go-version So apparently this provider didn't get that encoded... oh boy very inconsistent setup we have

Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass, sorry about the back and forth on the .go-version stuff

@appilon appilon merged commit 118b89d into master Mar 3, 2020
@appilon appilon deleted the migrate-to-plugin-sdk branch March 3, 2020 15:46
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants