Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Zero G favors axis aligned movement #632

Open
5 tasks done
Kevadroz opened this issue Oct 5, 2024 · 2 comments
Open
5 tasks done

[Bug]: Zero G favors axis aligned movement #632

Kevadroz opened this issue Oct 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Kevadroz
Copy link

Kevadroz commented Oct 5, 2024

Bug Description

When on space stations, any attempt to move while running in a non-cardinal direction will result in perceptibly the same speed as moving while not running, while running while facing a cardinal axis will result in a considerable speed gain.

How to Reproduce?

  1. Get into a zero g environment (space station).
  2. Relocate yourself to a space without any blocks to walk on.
  3. Attempt to run diagonally.

Expected Behavior

Running while facing a non-cardinal direction results in moving at the same speed as running in a cardinal direction.

Version

1.15.18

Mod Loader Version

1.20.1 - 47.3.10

Mod Loader

Forge

Logs or additional context

No relevant logs. However from my own debugging I have deduced that this could be a symptom of MC-184530.

Code of Conduct

  • I have searched the issue tracker and confirmed that the issue has not been reported
  • I have checked the FAQ (if one is present) and my issue is not listed
  • I have verified that I am using the latest version of the mod
  • I have verified that I have installed all the required dependencies for the mod
  • I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.
@Kevadroz Kevadroz added the bug Something isn't working label Oct 5, 2024
@Kevadroz
Copy link
Author

Kevadroz commented Oct 5, 2024

After a bit more debugging I have found the cause of this bug: a bit of code in LivingEntity#aiStep just before the Entity#setDeltaMovement zeroes the motion if it's below a certain value. But this is done individually with x, y and z. causing this problem.

@Kevadroz
Copy link
Author

Kevadroz commented Oct 5, 2024

After creating a mixin to lower the minimum speed an entity can have I have also discovered that this bug makes walking have a significant lower speed than intended, moving at a constant 0.001~ blocks per (tick? second?) instead of the slow acceleration that exists with this mixin applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant