Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage title doesn't align in IE11 #19

Open
KyrietS opened this issue Aug 5, 2019 · 2 comments
Open

Homepage title doesn't align in IE11 #19

KyrietS opened this issue Aug 5, 2019 · 2 comments

Comments

@KyrietS
Copy link

KyrietS commented Aug 5, 2019

Bug description

align-items: center; doesn't work in IE11 when used on container with min-width specified only.

Screenshot from IE11
a

More details

Workaround with details and discussion
philipwalton/flexbugs#231

Similar problem (Stackoverflow)
https://stackoverflow.com/questions/19371626/flexbox-not-centering-vertically-in-ie

Suggested solution

.section-intro should have: height instead of min-height. There is overflow: hidden anyway so this change shouldn't cause any changes at all. This change fixes aligning in IE11 though.

Homepage after applied fix

b

Tested on

Internet Explorer 11
Version: 11.615.17763.0
Update version: 11.0.135

@terrylinooo
Copy link
Owner

IE doesn't support CSS flexbox.

@KyrietS
Copy link
Author

KyrietS commented Aug 6, 2019

IE11 has partial support with some bugs. See:
https://caniuse.com/#search=CSS%20Flexible%20Box%20Layout

Look at Known issues tab. Our problem is mentioned there.
I understand that IE11 support is not important but except for this homepage title aligning bug, whole website with Mynote looks great. So if we can fix it with one simple change, I think it's worth it.

If you don't want to mess with IE anyway, that's ok. I accept that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants