Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add additional validation to validator.py that provides command count #18

Closed
cantechit opened this issue Dec 26, 2021 · 5 comments

Comments

@cantechit
Copy link

Feature Req: The existing validator.py doesn't provide enough granular information about why light-show output files from xLights are too large, the Memory % value seems to wildly fluctuate higher even when commands are removed

@bendudz
Copy link

bendudz commented Dec 26, 2021

The validation results give a frame count if the FSEQ is valid. The documentation states max command count (transition of light / closure state ie on -> off / open -> closed etc) is 681 but bear in mind, commands that start at the same timestamp counts as 1 command.

Memory usage is calculated taking the number of commands & dividing it by 681.

@bendudz
Copy link

bendudz commented Dec 27, 2021

I’ve revisited your comments & now include total commands used in my PR #20

@entendu
Copy link

entendu commented Dec 28, 2021

+1, was looking for this

@JVB-Tesla
Copy link
Collaborator

Good suggestion. We'll make this change.

@entendu
Copy link

entendu commented Jan 6, 2022

@JVB-Tesla see pr #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants