Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN 0.71 support #519

Closed
tarouboy opened this issue Jan 25, 2023 · 5 comments
Closed

RN 0.71 support #519

tarouboy opened this issue Jan 25, 2023 · 5 comments

Comments

@tarouboy
Copy link

Describe the bug
After upgrading to RN 0.71.1, no longer able to build the app for Android.
I believe it is because the targetSdkVersion became 33.

Task :react-native-camera-kit:compileDebugKotlin FAILED
e: /Users/___/Desktop/reactnative/___/node_modules/react-native-camera-kit/android/src/main/java/com/rncamerakit/CKCamera.kt: (183, 17): 'onScale' overrides nothing

To Reproduce
Steps to reproduce the behavior:

  1. Create new RN project with latest version
  2. Add react-native-camera-kit
  3. run npx react-native start android and it will stop building with the above error.

Expected behavior
Able to build the app

Smartphone (please complete the following information):

  • Device: Any simulator
  • OS: Android

Additional context
For now, I have commented the scaleDetector on CKCamera.kt. Not sure if it will cause any other troubles.

@Fagner3g
Copy link

Fagner3g commented Feb 7, 2023

same problem here :/

@d3v2a
Copy link

d3v2a commented Feb 26, 2023

Have you followed this guide ?

Work for me with

kotlin_version = '1.7.21'

I don't have added apply plugin in android/app/build.gradle

@corderogerardo
Copy link

Have you followed this guide ?

Work for me with

kotlin_version = '1.7.21'

I don't have added apply plugin in android/app/build.gradle

This worked for me! Thanks @d3v2a

@ghitete
Copy link

ghitete commented May 22, 2023

It works but in my case, higher kotlin version is not compatible with other packages

@scarlac
Copy link
Collaborator

scarlac commented Jun 12, 2023

Fixed in #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@scarlac @d3v2a @corderogerardo @Fagner3g @tarouboy @ghitete and others