Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is location needed for VehicleControlWindowAction? #239

Closed
itsMeDavidV opened this issue May 15, 2024 · 2 comments · Fixed by #241
Closed

Is location needed for VehicleControlWindowAction? #239

itsMeDavidV opened this issue May 15, 2024 · 2 comments · Fixed by #241

Comments

@itsMeDavidV
Copy link

Is location needed as a parameter here?

message VehicleControlWindowAction {
    LatLong location = 1;
    oneof action {
        Void unknown = 2;
        Void vent = 3;
        Void close = 4;
    }
}

I noticed you can send window control commands without the location parameter populated and the vehicle will execute the command successfully. I also noticed the vehicle-command SDK also does not populate the location parameter.

So going forward I'd like to have a little clarity on this: is location data ever needed for window control and if so when?

If not, will the proto be amended?

@sethterashima
Copy link
Collaborator

The location parameter is not required on vehicles that require newer protocol. Will remove from the protobuf.

@itsMeDavidV
Copy link
Author

itsMeDavidV commented May 17, 2024

not required on vehicles that require newer protocol

@sethterashima ah so location parameter would still be required for older vehicles that don't use the protocol?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants