Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate endpoint "Cut member not found" #306

Open
palamago opened this issue Feb 8, 2021 · 2 comments
Open

Aggregate endpoint "Cut member not found" #306

palamago opened this issue Feb 8, 2021 · 2 comments

Comments

@palamago
Copy link

palamago commented Feb 8, 2021

In an Aggregate query like: /cubes/demre_applications/aggregate.jsonrecords?cuts%5B%5D=Report+Year.Year.Year.2020&cuts%5B%5D=Institution.Institution.Institution.7,86,117,70,10,75,76,74,83,71,78&cuts%5B%5D=Preference+Status.Preference+Status.Preference+Status.24&cuts%5B%5D=Career.Career.Generic+Career.193,81,79,82,267,22,157,158,247,188,78,17&drilldowns%5B%5D=Career.Career.Generic+Career&drilldowns%5B%5D=Institution.Institution.Institution&drilldowns%5B%5D=Report+Year.Year.Year&measures%5B%5D=Last%20Enrolled%20Score&parents=false&sparse=false

Tesseract returns 404 with a message:
"Cut member not found"

It means that some id (not sure which one) set in cut param is not present in the members list in this cube/dimension.

Is this behavior correct?
Ignore the cut if not present is not a better plan?

@frabarz
Copy link
Contributor

frabarz commented Feb 8, 2021

I think failing loudly is a better approach than failing silently.
We could have a situation where the failing id is actually in the database but the operations can't find it, which might be an indication of a problem in the ingestion process or with tesseract's code itself.

@hwchen
Copy link
Collaborator

hwchen commented Feb 15, 2021

Not sure why I didn't add which cut member is not found to the error message.

I'm a fan of failing loudly, at least for the core tesseract api. I think that logic layer is more lenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants