Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Hermes ES6 score #50

Open
tmikov opened this issue Mar 9, 2024 · 1 comment
Open

Improved Hermes ES6 score #50

tmikov opened this issue Mar 9, 2024 · 1 comment
Labels
results Error in results

Comments

@tmikov
Copy link

tmikov commented Mar 9, 2024

Hermes has two experimental options that can potentially improve the results: --block-scoping and -Xes6-class. How difficult would it be to pass them?

FWIW, it looks not exactly trivial. I think hermes is invoked from https://github.com/CanadaHonk/test262.fyi/blob/78cb8ddcf97cb42c3c40117d35bc6d484caf0437/.github/workflows/run.yml and I don't see an obvious way to pass special arguments there (but I know nothing about Git workflows). Perhaps an easier alternative would be to create a wrapper shell-script and invoke that?

@CanadaHonk
Copy link
Member

I'm somewhat hesitant to add arguments which are not on by default for most cases, are the options commonly used / why are they off by default?

@CanadaHonk CanadaHonk added the results Error in results label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
results Error in results
Projects
None yet
Development

No branches or pull requests

2 participants