Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NJS #72

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Add NJS #72

merged 1 commit into from
Aug 10, 2024

Conversation

linusg
Copy link
Member

@linusg linusg commented Aug 9, 2024

Depends on CanadaHonk/eshost#17

Closes #71

@linusg linusg mentioned this pull request Aug 9, 2024
@linusg
Copy link
Member Author

linusg commented Aug 9, 2024

TODO before merging: Install gcc, make, and NJS build dependencies on the runner host

@xeioex
Copy link

xeioex commented Aug 9, 2024

hi @linusg

you do not need zlib1g-dev libssl-dev libxml2-dev libxslt-dev for NJS engine itself. These packets are for extension modules. Only PCRE2 is essential.

@linusg linusg marked this pull request as ready for review August 10, 2024 12:13
Copy link
Member

@CanadaHonk CanadaHonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CanadaHonk CanadaHonk merged commit 308d7b8 into main Aug 10, 2024
@linusg linusg deleted the njs branch August 10, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add NJS support
3 participants