Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NJS support #71

Closed
michaelficarra opened this issue Aug 8, 2024 · 6 comments · Fixed by #72
Closed

add NJS support #71

michaelficarra opened this issue Aug 8, 2024 · 6 comments · Fixed by #72

Comments

@michaelficarra
Copy link

See https://github.com/nginx/njs

NJS is a complete JavaScript engine developed to be embedded in nginx as a dynamic nginx module. NJS can be run outside of nginx using the CLI or the REPL: https://nginx.org/en/docs/njs/cli.html. It would be nice to be able to see how it compares to other popular engines on spec compliance. If you need help, I should be able to connect you with the NJS devs, so just let me know.
@CanadaHonk
Copy link
Member

TIL it uses its own engine (mostly?), definitely interested in adding it!

@linusg
Copy link
Member

linusg commented Aug 8, 2024

Do they have or are willing to add the functions required for an eshost-compatible runtime? (https://github.com/CanadaHonk/eshost/tree/master/runtimes)

@michaelficarra
Copy link
Author

TIL it uses its own engine (mostly?), definitely interested in adding it!

Yep, completely from scratch as far as I'm aware.

Do they have or are willing to add the functions required for an eshost-compatible runtime?

I'll ask!

@linusg linusg mentioned this issue Aug 9, 2024
Merged
@linusg
Copy link
Member

linusg commented Aug 9, 2024

I added basic NJS support to our eshost fork in CanadaHonk/eshost#17, the stubbed methods are what would be needed on their end for a complete runtime. This is not blocking, it just means that certain tests won't run.

@linusg linusg mentioned this issue Aug 9, 2024
Merged
@linusg
Copy link
Member

linusg commented Aug 9, 2024

Draft PR for NJS test262.fyi integration: #72

@linusg
Copy link
Member

linusg commented Aug 10, 2024

@michaelficarra results are in: https://test262.fyi/#%7Cnjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NJS test262-fyi/test262.fyi
3 participants
@michaelficarra @CanadaHonk @linusg