break: use a docker image type for modules #2744
Draft
+134
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lanwen
reviewed
Aug 22, 2024
| // Valid examples: | ||
| // - "alpine:3.12" | ||
| // - "docker.io/nginx:latest" | ||
| // - "my-registry.local:5000/my-image:my-tag" |
There was a problem hiding this comment.
Would be sha256:abc... form valid as well? Could you add example to the doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a new type alias for string to represent Docker image names, which will be used in the signature of all the Run functions in the modules.
All calls to Run with an untyped string will not break, but users of the lib passing a typed string will have to change it to a
testcontainers.DockerImage.Why is it important?
It will allow providing support for the compatible-for feature in testcontainers-java, among other Docker image validations.