Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: improve the experience using log producers #525

Closed
mdelapenya opened this issue Sep 15, 2022 · 1 comment · Fixed by #2073
Closed

[Enhancement]: improve the experience using log producers #525

mdelapenya opened this issue Sep 15, 2022 · 1 comment · Fixed by #2073
Labels
feature New functionality or new behaviors on the existing one hacktoberfest Pull Requests accepted for Hacktoberfest.

Comments

@mdelapenya
Copy link
Member

mdelapenya commented Sep 15, 2022

Proposal

When needing to check logs for a container, we have to:

  • define a log producer
  • implement the accept function

This is fairly simple, but not very developer friendly.

We could provide a default log producer that outputs container logs to console, which is enabled/disabled in the container request, default true.

Then we would be able to see container logs at the moment they are produced.

We could start with a simple LogProducer bool, or an array of log producers for the case we want to send the logs to any other place, i.e. to elasticsearch 🤷

@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Sep 15, 2022
@mdelapenya mdelapenya added the hacktoberfest Pull Requests accepted for Hacktoberfest. label Sep 29, 2022
@mritunjaysharma394
Copy link
Contributor

mritunjaysharma394 commented May 24, 2023

Is it still required yes? if yes then I would love to contribute to this, since I also needed it while debugging while I was adding k3s modules, I think this can be a good feature to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants