Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IPAM configs to NetworkRequest #394

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

aivinog1
Copy link
Contributor

@aivinog1 aivinog1 commented Jan 4, 2022

I've added a new field for NetworkRequest

closes #299

@mdelapenya
Copy link
Member

@aivinog1 could you please 🙏 rebase and push to trigger the tests? I do not have permissions yet to force a merge/rebase, so I'd appreciate if you can do it. Sorry for bugging you 😢

@aivinog1
Copy link
Contributor Author

@aivinog1 could you please 🙏 rebase and push to trigger the tests? I do not have permissions yet to force a merge/rebase, so I'd appreciate if you can do it. Sorry for bugging you 😢

@mdelapenya it is done, no problem 🙂

@mdelapenya
Copy link
Member

mdelapenya commented May 26, 2022

I see this error in the GH action: https://github.com/testcontainers/testcontainers-go/runs/6604669282?check_suite_focus=true

=== FAIL: . Test_NetworkWithIPAM (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xac7e40]

Could you please take a look?

@aivinog1
Copy link
Contributor Author

aivinog1 commented Jun 5, 2022

@mdelapenya Hey, I fixed it, let's try again :)

@aivinog1 aivinog1 requested a review from mdelapenya June 5, 2022 14:23
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #394 (c77d94f) into main (1f42bf6) will increase coverage by 0.38%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   65.16%   65.55%   +0.38%     
==========================================
  Files          19       19              
  Lines        1180     1199      +19     
==========================================
+ Hits          769      786      +17     
- Misses        304      305       +1     
- Partials      107      108       +1     
Impacted Files Coverage Δ
container.go 87.23% <ø> (ø)
wait/wait.go 100.00% <ø> (ø)
docker.go 65.69% <58.33%> (+0.37%) ⬆️
wait/exec.go 92.00% <100.00%> (ø)
wait/host_port.go 56.14% <100.00%> (ø)
reaper.go 79.68% <0.00%> (+0.37%) ⬆️
compose.go 76.77% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb7f60...c77d94f. Read the comment docs.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here @aivinog1!

@mdelapenya mdelapenya merged commit c6d9b74 into testcontainers:main Jun 6, 2022
@aivinog1 aivinog1 deleted the 299-network-ipam branch June 6, 2022 12:34
@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to configure IPAM for networks
2 participants