-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IPAM configs to NetworkRequest
#394
Conversation
@aivinog1 could you please 🙏 rebase and push to trigger the tests? I do not have permissions yet to force a merge/rebase, so I'd appreciate if you can do it. Sorry for bugging you 😢 |
37f6bf6
to
e9cf05c
Compare
@mdelapenya it is done, no problem 🙂 |
I see this error in the GH action: https://github.com/testcontainers/testcontainers-go/runs/6604669282?check_suite_focus=true
Could you please take a look? |
@mdelapenya Hey, I fixed it, let's try again :) |
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 65.16% 65.55% +0.38%
==========================================
Files 19 19
Lines 1180 1199 +19
==========================================
+ Hits 769 786 +17
- Misses 304 305 +1
- Partials 107 108 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job here @aivinog1!
I've added a new field for
NetworkRequest
closes #299