-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks fail if Docker version contains a non-numeric classifier. #1220
Comments
Mmm.. no, It seemingly reports the version of the server just as What is just sad is that I cannot skip this check by setting |
Hey Schalk, cool to see you using Testcontainers 🙂 testcontainers-java/core/src/main/java/org/testcontainers/DockerClientFactory.java Line 145 in 8acee4d
We can solve this by either moving Docker version check into the same condition as the other checks, or by making the version checking more tolerant. |
I think just the ability to turn the check off would be good enough. In general I think the version check is important. I have updated the initial description of this issue with clarification as to what needs fixing. P.S. As the issue that triggered this is with a specific Linux distro I have also raised the appropriate bug with them: https://bugs.mageia.org/show_bug.cgi?id=24321 |
Yeah, lets go with letting this check be turned off. Docker 1.6.0 is pretty ancient, so as a check it's not really that valuable. |
Hello there! |
Hey @aiviniog1, |
I have create PR with a new setting to disable check Docker version. I think I need to update docs, but I can't find appropriate article. Any advice? Or may be I need to create a new one? |
Hmm, this page is probably the right one: https://www.testcontainers.org/features/configuration/ However, it already implies that the version check is disabled by Thank you! |
@rnorth Thank you for your answer. It's stands more clear now. I understand so there don't need additional setting. I have already changed my PR accordingly. Bottom line: The setting |
On one of my Linux system the version
from docker version
is reported as18.06.0-dev
. This causes the version check to fail as it assumes that the version should be purely dots and numbers.Edit: The correct fix for this should be the following:
checks.disable=true
The text was updated successfully, but these errors were encountered: