-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker 1.12 support: "starting container with HostConfig was deprecated since v1.10 and removed in v1.12" #163
Comments
Yes, it's docker-java/docker-java#615. Which version of docker is this |
I'm on 1.12.0-rc2, installed via Docker for Mac beta16 (build: 9493) |
I can confirm this issue on Docker for Mac. Looks like it's built not from official github Docker repo, as code it repo still considers HostConfig as a warning, not error. This issue breaks PyCharm support for Docker as well. |
Docker Version 1.12.0-rc2-beta16 (build: 9493) |
Which version of Testcontainers is this affecting you on? The main 1.0.5 release? I've been mainly working on the docker-compose-refactor branch recently, but have gone back to its predecessor 1.1-rc1 branch to test - that seems to be working. I'd like to try and get the 1.1 release out this weekend for Docker for Mac support, so I hope this will help. Any extra testing would be much appreciated, though. |
Sorry, I'm not using testcontainers, I've got to this issue from docker-java/docker-java#615 |
I see this error with the integration tests in the docker-java directly using 1.12 server api. The unit tests pass ok. |
+1 |
@margic it sounds like you're encountering this problem on the docker-java project, not the testcontainers project which this ticket belongs to. Is that correct? @stepan-romankov similarly, are you a testcontainers user? |
Here they pushed changes to fix this issue |
I'd be interested to see if this is occurring for people now with Testcontainers v1.1.0 and Docker for Mac beta releases - it works for me. |
Using v1.1.0 I get this on linux
On Mac I get this
in a loop that never ends |
Also, found this in the logs
|
@ihabsoliman thanks - those logs you've pasted look like a different thing to what's in this ticket, but do look like #170. Let's continue that analysis over there. |
Ah sorry, mixed up tabs, yea your right. |
I'm inclined to mark as closed, since I've not been able to reproduce since the earlier dev version of DfM support, and since there have been no reports since 1.1.0. |
This looks like an upstream issue with docker-java, but I can't quite reconcile it -- it looks like the deprecated options were removed some time ago (docker-java/docker-java#248)
The text was updated successfully, but these errors were encountered: