Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerComposeContainer.registerContainersForShutdown() not finding spawned containers #194

Closed
valdisrigdon opened this issue Aug 2, 2016 · 5 comments

Comments

@valdisrigdon
Copy link
Contributor

valdisrigdon commented Aug 2, 2016

The listContainersCmd is returning 0 containers. If I run the same listContainersCmd without withLabelFilter, I can see my 3 containers listed.

This is connecting via docker-machine:

016-08-02 01:58:43,542 [main] INFO  org.testcontainers.DockerClientFactory - Connected to docker: 
  Server Version: 1.11.0
  API Version: 1.23
  Operating System: Boot2Docker 1.11.0 (TCL 7.0); HEAD : 32ee7e9 - Wed Apr 13 20:06:49 UTC 2016
@rnorth
Copy link
Member

rnorth commented Aug 6, 2016

Thanks - this is odd. I started using the label filter on name a little while ago, thinking it was cleaner than the previous fetch-then-filter approach.

I wonder, could this be something to do with the leading slash in the filter ("name=/" + identifier) do you think? I recall having some trouble with presence of the slash being inconsistent in the past.

@valdisrigdon
Copy link
Contributor Author

I tried with and without the slash, but couldn't get anything to come back. It was kind of strange. The command line docker ps with the --filter option worked.

@outofcoffee
Copy link
Contributor

@valdisrigdon @rnorth I fixed the enumeration of child container IDs in #233 - could you retest?

@bsideup
Copy link
Member

bsideup commented Jan 15, 2017

Hey @valdisrigdon, can we close this issue or it's still there?

@bsideup
Copy link
Member

bsideup commented Apr 11, 2018

Closing due to inactivity. We also improved the cleanup in 1.6.0 with "Death Note" feature (see #545 ).

@bsideup bsideup closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants