Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing privileged support for docker container #234

Closed
grimmjo opened this issue Oct 22, 2016 · 7 comments
Closed

Missing privileged support for docker container #234

grimmjo opened this issue Oct 22, 2016 · 7 comments
Milestone

Comments

@grimmjo
Copy link
Contributor

grimmjo commented Oct 22, 2016

While I was using the GenericContainer I found a problem using it. There is the privileged option missing. Since I'm using a IBM DB2 in project in a docker container, I need that support of docker.

@rnorth
Copy link
Member

rnorth commented Oct 24, 2016

Hi @jojo255
Thanks for this - good idea!
Richard

@bsideup
Copy link
Member

bsideup commented Oct 24, 2016

@rnorth I see implementation and feel that we really should move to 2.0 and traits :)

@grimmjo
Copy link
Contributor Author

grimmjo commented Oct 24, 2016

@bsideup @rnorth
Do you have any clue why the circleci build has failed? Haven't changed anything there and I think I didn't destroyed anything :-D

@rnorth
Copy link
Member

rnorth commented Oct 24, 2016

Sadly we have a couple of flapping tests that fail more frequently on CircleCI - it's likely to be one of those :(
I need to address when I have a bit of time...

@grimmjo
Copy link
Contributor Author

grimmjo commented Nov 4, 2016

@rnorth
Is there a roadmap for 2.0 or any plans when it should be released or the work get's started

@rnorth
Copy link
Member

rnorth commented Nov 7, 2016

@jojo255 thanks for this, and sorry for taking such a long time to respond. This PR looks good to me so I'll merge. The Circle CI failure is, unfortunately, random and I'm thinking of disabling that for CI (Travis is serving us a bit better).

Re 2.0, I think @bsideup was suggesting that this change is good justification for something we want to do in 2.0, but it doesn't have to wait until 2.0. I'm not sure about 2.0 release timeframe - likely early next year rather than this year.

I'll merge and try and release ASAP, though.

@rnorth rnorth modified the milestone: 1.1.7 Nov 19, 2016
@rnorth
Copy link
Member

rnorth commented Nov 20, 2016

Released in 1.1.7 - sorry for the delay in getting this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants