Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Docker for Mac with 1.13 #272

Merged
merged 1 commit into from
Jan 21, 2017
Merged

fix for Docker for Mac with 1.13 #272

merged 1 commit into from
Jan 21, 2017

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Jan 20, 2017

No description provided.

@bsideup bsideup mentioned this pull request Jan 20, 2017
Closed
@bsideup bsideup requested a review from rnorth January 20, 2017 21:53
@bsideup bsideup added this to the 1.1.8 milestone Jan 20, 2017
@bsideup
Copy link
Member Author

bsideup commented Jan 20, 2017

@rnorth locally build green as well

@rnorth
Copy link
Member

rnorth commented Jan 21, 2017

Nice! I'll test locally and aim to release ASAP.

rnorth
rnorth approved these changes Jan 21, 2017
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm assuming that LXC and Docker 1.13.0 are not a combination we'll expect to see. If somehow that ever happens (can it?) we might need to rethink, but this change is fine as-is.

@rnorth rnorth merged commit 638e4d0 into master Jan 21, 2017
@rnorth rnorth deleted the docker4mac_1_13_fix branch January 21, 2017 05:59
@wu-sheng wu-sheng mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.1.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsideup @rnorth