Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed shadowing scope of guava packages #292

Merged
merged 1 commit into from
Feb 17, 2017
Merged

changed shadowing scope of guava packages #292

merged 1 commit into from
Feb 17, 2017

Conversation

coutoPL
Copy link
Contributor

@coutoPL coutoPL commented Feb 15, 2017 •
edited
Loading

Guava com.google.thirdparty package was not shadowed.

Before:

$ jar tvf testcontainers-1.1.9.jar | less
...
53288 Sun Feb 12 21:01:26 CET 2017 com/google/thirdparty/publicsuffix/PublicSuffixPatterns.class
2421 Sun Feb 12 21:01:26 CET 2017 com/google/thirdparty/publicsuffix/PublicSuffixType.class
4186 Sun Feb 12 21:01:26 CET 2017 com/google/thirdparty/publicsuffix/TrieParser.class
...

After:

$ jar tvf testcontainers-1.1.10-SNAPSHOT.jar | less
...
53392 Wed Feb 15 16:10:48 CET 2017 org/testcontainers/shaded/com/google/thirdparty/publicsuffix/PublicSuffixPatterns.class
2629 Wed Feb 15 16:10:48 CET 2017 org/testcontainers/shaded/com/google/thirdparty/publicsuffix/PublicSuffixType.class
4368 Wed Feb 15 16:10:48 CET 2017 org/testcontainers/shaded/com/google/thirdparty/publicsuffix/TrieParser.class
...

@bsideup bsideup added this to the 1.1.10 milestone Feb 15, 2017
@bsideup bsideup merged commit b38709c into testcontainers:master Feb 17, 2017
@sscarduzio sscarduzio mentioned this pull request Feb 23, 2017
Merged
rnorth added a commit that referenced this pull request Mar 12, 2017
@rnorth
Update CHANGELOG for 1.2.0 release:
1ef0193 
## [1.2.0] - 2017-03-12
### Fixed
- Fix various escaping issues that may arise when paths contain spaces (#263, #279)
- General documentation fixes/improvements (#300, #303, #304)
- Improve reliability of `ResourceReaper` when there are a large number of containers returned by `docker ps -a` (#295)

### Changed
- Support Docker for Windows via TCP socket connection (#291, #297, #309). _Note that Docker Compose is not yet supported under Docker for Windows (see #306)
- Expose `docker-java`'s `CreateContainerCmd` API for low-level container tweaking (#301)
- Shade `org.newsclub` and Guava dependencies (#299, #292)
- Add `org.testcontainers` label to all containers created by Testcontainers (#294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coutoPL @bsideup