Modify Selenium container startup detection #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess string observed in v3.x of Selenium containers.
martin-g
approved these changes
May 30, 2017
bsideup
reviewed
Jun 1, 2017
|
|
||
| @Test | ||
| public void testAdditionalStartupString() { | ||
| BrowserWebDriverContainer chrome = new BrowserWebDriverContainer("selenium/standalone-chrome-debug:" + tag) |
There was a problem hiding this comment.
you can use try-with-resources here
| * Simple test to check that readiness detection works correctly across major versions of the containers. | ||
| */ | ||
| @RunWith(Parameterized.class) | ||
| public class Selenium3xTest extends BaseWebDriverContainerTest { |
There was a problem hiding this comment.
I think we can remove "extends BaseWebDriverContainerTest" because we don't use anything from it
kiview
approved these changes
Jun 3, 2017
| @@ -56,7 +56,7 @@ | |||
| */ | |||
| public BrowserWebDriverContainer() { | |||
| this.waitStrategy = new LogMessageWaitStrategy() | |||
| .withRegEx(".*RemoteWebDriver instances should connect to.*\n") | |||
| .withRegEx(".*Selenium Server is up and running.*\n") | |||
There was a problem hiding this comment.
Is this String available in all versions? Because I thought you wanted something like
".*(RemoteWebDriver instances should connect to)|(Selenium Server is up and running).*\n"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... using alternative readiness string observed in v3.x of Selenium containers.
It seems that somewhere along the line the string that the selenium containers use to signal readiness has changed. This commit fixes that issue by allowing either string to be detected. The test tries two tag versions with differing outputs.
FYI @bsideup @kiview