Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Hard coded AccessKey / SecretKey in LocalStackContainer doesn't match LocalStack #7623

Closed
internetstaff opened this issue Oct 6, 2023 · 4 comments

Comments

@internetstaff
Copy link

Module

LocalStack

Testcontainers version

1.19.1

Using the latest Testcontainers version?

Yes

Host OS

Linux

Host Arch

x86_64

Docker version

24.0.5

What happened?

We've been configuring credentials per the examples (calling LocalStackContainer.getAccessKey() and LocalStackContainer.getSecretKey(), and everything generally works fine because LocalStack doesn't care.

Where it fails is when we set S3_SKIP_SIGNATURE_VALIDATION to 0 and try to test passing / failing S3 signatures.

LocalStack defaults to test for both access and secret key, and if the S3Client isn't set to the same, the signatures are invalid.

If LocalStackContainer used these same values, it seems like everything would "just work" and spare someone else debugging this.

I may be missing a bigger picture here as to why these values don't match LocalStack. :)

Relevant log output

No response

Additional Information

No response

@eddumelendez
Copy link
Member

Thanks for the report, @internetstaff ! Would you like to contribute?

@fokion
Copy link
Contributor

fokion commented Oct 23, 2023

I can have a look if you want @eddumelendez

@eddumelendez
Copy link
Member

@fokion the issue is yours. Please, consider adding tests.

@fokion
Copy link
Contributor

fokion commented Oct 24, 2023

Working towards this draft PR #7718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants