Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize type definitions #145

Closed
kentcdodds opened this issue Jul 25, 2020 · 4 comments
Closed

Internalize type definitions #145

kentcdodds opened this issue Jul 25, 2020 · 4 comments
Assignees

Comments

@kentcdodds
Copy link
Member

kentcdodds commented Jul 25, 2020

It would help with issues like #121 and in general I don't think there's a lot of value having them externalized to DefinitelyTyped (https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__cypress). Let's bring them in.

Anyone wanna work on this?

@TheGallery
Copy link
Collaborator

I am happy to pick this up.

@TheGallery
Copy link
Collaborator

This one is in progress. I am encountering some issues with conflicting type definitions but it's getting there.

@TheGallery
Copy link
Collaborator

I haven't been able to figure this out and I am kind of stuck now :-/ I am quoting my message on Discord about the issue

So, the precommit hook complains when running tsc because some jest and cypress type definitions are conflicting. I've looked into other similar PRs in testing-library packages but I couldn't find a solution.

Is it worth opening a PR with what I have so far?

@kentcdodds
Copy link
Member Author

Yes, please skip the hook if it's preventing you from opening your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants