refactor: remove mechanism to match files to be reported (#297)

testing-library · Mar 23, 2021 · 69d5bbe · 69d5bbe
1 parent 461809f
commit 69d5bbe
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 297 deletions.
diff --git a/lib/detect-testing-library-utils.ts b/lib/detect-testing-library-utils.ts
@@ -27,7 +27,6 @@ import {
 
 export type TestingLibrarySettings = {
   'testing-library/utils-module'?: string;
-  'testing-library/filename-pattern'?: string;
   'testing-library/custom-renders'?: string[];
 };
 
@@ -56,7 +55,6 @@ type GetCustomModuleImportNodeFn = () => ImportModuleNode | null;
 type GetTestingLibraryImportNameFn = () => string | undefined;
 type GetCustomModuleImportNameFn = () => string | undefined;
 type IsTestingLibraryImportedFn = () => boolean;
-type IsValidFilenameFn = () => boolean;
 type IsGetQueryVariantFn = (node: TSESTree.Identifier) => boolean;
 type IsQueryQueryVariantFn = (node: TSESTree.Identifier) => boolean;
 type IsFindQueryVariantFn = (node: TSESTree.Identifier) => boolean;
@@ -90,7 +88,6 @@ export interface DetectionHelpers {
   getTestingLibraryImportName: GetTestingLibraryImportNameFn;
   getCustomModuleImportName: GetCustomModuleImportNameFn;
   isTestingLibraryImported: IsTestingLibraryImportedFn;
-  isValidFilename: IsValidFilenameFn;
   isGetQueryVariant: IsGetQueryVariantFn;
   isQueryQueryVariant: IsQueryQueryVariantFn;
   isFindQueryVariant: IsFindQueryVariantFn;
@@ -110,8 +107,6 @@ export interface DetectionHelpers {
   isNodeComingFromTestingLibrary: IsNodeComingFromTestingLibraryFn;
 }
 
-const DEFAULT_FILENAME_PATTERN = '^.*\\.(test|spec)\\.[jt]sx?$';
-
 const FIRE_EVENT_NAME = 'fireEvent';
 const RENDER_NAME = 'render';
 
@@ -132,9 +127,6 @@ export function detectTestingLibraryUtils<
 
     // Init options based on shared ESLint settings
     const customModule = context.settings['testing-library/utils-module'];
-    const filenamePattern =
-      context.settings['testing-library/filename-pattern'] ??
-      DEFAULT_FILENAME_PATTERN;
     const customRenders = context.settings['testing-library/custom-renders'];
 
     /**
@@ -243,15 +235,6 @@ export function detectTestingLibraryUtils<
       );
     };
 
-    /**
-     * Determines whether filename is valid or not for current file
-     * being analyzed based on "testing-library/filename-pattern" setting.
-     */
-    const isValidFilename: IsValidFilenameFn = () => {
-      const fileName = context.getFilename();
-      return !!fileName.match(filenamePattern);
-    };
-
     /**
      * Determines whether a given node is `get*` query variant or not.
      */
@@ -536,7 +519,7 @@ export function detectTestingLibraryUtils<
      * Determines if file inspected meets all conditions to be reported by rules or not.
      */
     const canReportErrors: CanReportErrorsFn = () => {
-      return isTestingLibraryImported() && isValidFilename();
+      return isTestingLibraryImported();
     };
 
     /**
@@ -566,7 +549,6 @@ export function detectTestingLibraryUtils<
       getTestingLibraryImportName,
       getCustomModuleImportName,
       isTestingLibraryImported,
-      isValidFilename,
       isGetQueryVariant,
       isQueryQueryVariant,
       isFindQueryVariant,