-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes for next v5 #478
Comments
Do we enable them in all configs or only in specific framework configs?
This means we can just make
I think we should keep |
I'd say in all applicable ones:
Indeed!
As you mentioned, this is about the specific |
🎉 This issue has been resolved in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 6.0.0-alpha.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 6.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I have a couple of breaking changes I think we should introduce in the new major version taking advantage of having to support ESLint 8
This project is maintained by volunteers. Support will be added as time permits.
If you're not willing or able to help with adding support:
This update will require breaking changes on our side as well, so it will take some time to support it.
There is no ETA on this work. Again please be patient.
✅ = done
🕐 = in progress
🔲 = not yet started
✅ Enable more rules in the shared configs
✅
no-render-in-setup
Enable for
angular
,react
&vue
configs (dom
doesn't have a render method)✅
no-unnecessary-act
Enable for
react
configs✅
no-wait-for-multiple-assertions
Enable for all configs
✅
no-wait-for-side-effects
Enable for all configs
✅
no-wait-for-snapshot
Enable for all configs
✅
prefer-presence-queries
Enable for all configs
✅
prefer-query-by-disappearance
Enable for all configs
✅ Make
isStrict
optiontrue
by default forno-unnecessary-act
We have enabled this rule with
isStrict
to true in the shared configs, this option is still false by default. We should change it so it's true by default.isStrict
optiontrue
by default #479✅ Rules rename
We have some inconsistencies in naming some of our rules regarding using singular/plural.
✅
await-async-query
->await-async-queries
await-async-queries
#665✅
no-await-sync-query
->no-await-sync-queries
no-await-sync-queries
#666✅
no-debug
->no-debugging-utils
no-debugging-utils
#469The text was updated successfully, but these errors were encountered: