fix(no-node-access): false positives with props.children
#658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
npm run generate:rules-list
)npm run generate:configs
)Changes
children
,firstChild
orpreviousSibling
) is called byprops
, so if there's aprops.children
,props.firstChild
orprops.previousSibling
, then that code won't be reported as an errorContext
Closes #386 (at least the most common case, not all of the examples given in that issue).
This PR does not close/fix the deconstructed props case (mentioned by @Belco90 in #386):
But I am happy to make another PR about this case too (I just haven't figured out how to identify with AST).
P.S. If you feel that this PR is following the rules of Hactoberfest and this gets merged, it would be wonderful if this PR would be tagged with a hacktoberfest-accepted tag/label. Thanks!