Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-manual-cleanup): enable by default in React and Vue #659

Merged
merged 1 commit into from
Oct 2, 2022
Merged

feat(no-manual-cleanup): enable by default in React and Vue #659

merged 1 commit into from
Oct 2, 2022

Conversation

skovy
Copy link
Collaborator

@skovy skovy commented Oct 1, 2022

BREAKING CHANGE: enable no-manual-cleanup by default in React and Vue.

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • Enable no-manual-cleanup by default in React & Vue configs

Context

Resolves #617

BREAKING CHANGE: enable no-manual-cleanup by default in React and Vue
@Belco90 Belco90 merged commit 21504bf into testing-library:alpha Oct 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🎉 This PR is included in version 6.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@skovy skovy deleted the pr/enable-no-manual-cleanup branch October 2, 2022 18:49
@MichaelDeBoey MichaelDeBoey added v6 Next major v6 BREAKING CHANGE This change will require a major version bump labels Oct 2, 2022
@MichaelDeBoey MichaelDeBoey linked an issue Oct 4, 2022 that may be closed by this pull request
MichaelDeBoey pushed a commit that referenced this pull request Oct 4, 2022
BREAKING CHANGE: `no-manual-cleanup` is now enabled by default in the React & Vue configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump hacktoberfest-accepted released on @alpha v6 Next major v6
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enable no-manual-cleanup in corresponding shareable configs
3 participants