-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updates support for aria-required attribute in to-be-required
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnapse
requested changes
Mar 18, 2024
gnapse
approved these changes
May 2, 2024
🎉 This PR is included in version 6.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 24, 2024
Merged
This was referenced Aug 13, 2024
Closed
This was referenced Sep 6, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The non-semantic HTML element fails
toBeRequired
method even though aria-required is set astrue
- #481It does not implement this part of what's documented in MDN:
Why:
The current code only only adheres to
aria-required
attribute for a set of HTML elementsHow:
Updated the
toBeRequired
method to not depend on tag type or role type for elements witharia-required
attributeChecklist: