Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query selector fails with jsdom 26.0.0 to find for button#react-aria-:r22:.css-ofddhz svg #661

Open
kolorfilm opened this issue Jan 19, 2025 · 2 comments

Comments

@kolorfilm
Copy link

kolorfilm commented Jan 19, 2025

  • @testing-library/jest-dom version: 6.6.3
  • node version: 22.13
  • jest (or vitest) version: Vitest (3.0.1)
  • npm (or yarn) version: pnpm 9.15.4

Relevant code or config:

HTML looks like that:

<button
        aria-label="Delete"
        class="css-18cu5b5"
        data-rac=""
        data-testid="delete-button-0"
        id="react-aria-:r6:"
        type="button"
      >
        <svg
          fill="none"
          height="24"
          viewBox="0 0 24 24"
          width="24"
          xmlns="http://www.w3.org/2000/svg"
        >
         ...
        </svg>
</button>

What you did:

await userEvent.click(screen.getByTestId('delete-button-0'));

What happened:

Image

Since I updated jsdom to 26.0.0 I get SyntaxError: 'button#react-aria-:r22:.css-ofddhz svg' is not a valid selector.

The id seems to be valid and is generated by react-aria.

Reproduction:

Problem description:

According to react-aria this is a valid id.

adobe/react-spectrum#7624 (reply in thread)

Suggested solution:

@MichailShcherbakov
Copy link

MichailShcherbakov commented Jan 20, 2025

It looks like it has been broken in jsdom since 24.0.0.

Release note

Try to downgrade to the 23.2.0 version. This solution helped me solve the problem.

@kolorfilm
Copy link
Author

kolorfilm commented Jan 20, 2025

It looks like it has been broken in jsdom since 24.0.0.

Release note

Try to downgrade to the 23.2.0 version. This solution helped me solve the problem.

First I thought it is a nwsapi bug because when I overwrite the version for jsdom dependencies it works (jsdom uses nwsapi). I just started to be broken for me with jsdom 26.0.0.

  "pnpm": {
    "overrides": {
      "nwsapi": "2.2.13"
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants