fix: Prevent "missing act" warning for queued microtasks #1137

eps1lon · 2022-10-08T11:12:36Z

What:

Closes #1125
Closes #1051

Why:

Once the callback passed to waitFor resolves, there could be other microtasks scheduled.
If we now yield back from waitFor we restore the REACT_IS_ACT_ENVIRONMENT. However, the tester awaits the waitFor and before the runtime yields back to the event loop, it needs (by spec) to drain the scheduled microtasks. This may include state updates which now run without REACT_IS_ACT_ENVIRONMENT which triggers warning.

How:

Drain microtask queue before resolving waitFor call.

Checklist:

~~[ ]~~ Documentation added to the
docs site
Tests
~~[ ]~~ TypeScript definitions updated
Explainer
Test in issue repro: fix: No more "missing act" warning trv-wcaneira/act-warning-mcve#1
Test in issue repro: fix: No more "missing act" warning eps1lon/missing-act-setstate-finally-repro#1
~~[ ] Test with React 17~~ We no longer support React 17
Test on mui/material-ui: Test React Testing Library patch mui/material-ui#36221
Test in Klarna monorepo
Ready to be merged

codesandbox-ci · 2022-10-08T11:13:43Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bfd1db7:

Sandbox	Source
React	Configuration
react-testing-library-examples	Configuration

codecov · 2022-10-08T11:14:16Z

Codecov Report

Merging #1137 (bfd1db7) into alpha (1934bf2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             alpha     #1137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          181       192   +11     
  Branches        34        38    +4     
=========================================
+ Hits           181       192   +11

Flag	Coverage Δ
experimental	`100.00% <100.00%> (ø)`
latest	`100.00% <100.00%> (ø)`
next	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pure.js	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

MatanBobi

Looks good! :)

src/__tests__/end-to-end.js

robin-drexler · 2022-11-21T03:49:45Z

👋 @eps1lon, curious would this PR also address #1051 or this is a different issue? 🤔

Thanks a lot!

fastndead · 2022-12-30T07:41:57Z

Hey! is there an ETA for this fix? We've ran into the bunch not wrapped in act() warnings after React 18/RLT 13 update, too many to spot -fix, but these changes actually reduce the amount of failed test by 65%, so I'm really looking forward to this being released

heath-pack · 2023-01-25T13:25:20Z

Would love to get this in soon to try and reduce the noise from our specs, then I can see if we have any "actual" act warnings left

diogoredin · 2023-02-01T12:56:01Z

Hey @eps1lon, any chance this going to get merged soon? We are also facing some unexpected failing tests & act warnings after moving to RTL 13 (using the legacy root still). Thank you for your work 🙏

eps1lon · 2023-02-15T16:49:11Z

Hey! is there an ETA for this fix? We've ran into the bunch not wrapped in act() warnings after React 18/RLT 13 update, too many to spot -fix, but these changes actually reduce the amount of failed test by 65%, so I'm really looking forward to this being released

This is very helpful information, thank you!

We have a new major planned that will include some small breaking changes from /dom. I was hesitant to merge this PR but including it in a new major makes it a lot safer to land.

I'll clean this up, test on some larger repos and check how it performs.

Using testing-library/react-testing-library#1137

jsnajdr · 2023-03-18T08:46:01Z

src/pure.js

+        if (jestFakeTimersAreEnabled()) {
+          jest.advanceTimersByTime(0)
+        }
+      })


An observation: if I comment out this new await code that drains the microtask queue, all the end-to-end.js tests are still passing. Both macrotask and microtask, in all timer variants.

Seems the tests would need to be amended somehow to really reproduce the bug.

Added tests in #1215

… where act() warnings are displayed incorrectly testing-library/react-testing-library#1137

ak-beam · 2023-08-10T19:05:08Z

@eps1lon Would it be possible to backport this to the 12.x release series for codebases still on React 17?

MatanBobi · 2023-08-13T06:45:08Z

@ak-beam this fix was only merged to alpha and isn't merged to master yet.
Having said that, I don't think this will be backported because it uses IS_REACT_ACT_ENVIRONMENT which is only available in React 18.

eps1lon force-pushed the fix/nanotasks-troll branch from ab13864 to 065c316 Compare October 8, 2022 11:54

eps1lon mentioned this pull request Oct 8, 2022

test: Fail on unexpected console.warn and console.error #1139

Merged

2 tasks

eps1lon force-pushed the fix/nanotasks-troll branch from 065c316 to fb22f8a Compare October 8, 2022 11:59

MatanBobi approved these changes Oct 9, 2022

View reviewed changes

src/__tests__/end-to-end.js Show resolved Hide resolved

src/__tests__/end-to-end.js Outdated Show resolved Hide resolved

dgdavid mentioned this pull request Nov 24, 2022

[web] Update dependencies agama-project/agama#331

Merged

markmssd approved these changes Dec 19, 2022

View reviewed changes

eps1lon changed the base branch from main to alpha February 15, 2023 20:13

eps1lon added 2 commits February 16, 2023 11:24

Add intended behavior

b2f3968

fix: Prevent "missing act" warning for in-flight promises

d0da54c

eps1lon force-pushed the fix/nanotasks-troll branch from fb22f8a to d0da54c Compare February 16, 2023 10:24

eps1lon added 3 commits February 16, 2023 11:27

Disable TL lint rules in tests

d2940a5

Implementation without macrotask

d935fb1

Now I member

bfd1db7

eps1lon changed the title ~~fix: Prevent "missing act" warning for in-flight promises~~ fix: Prevent "missing act" warning for queued microtasks Feb 16, 2023

eps1lon mentioned this pull request Feb 16, 2023

Test React Testing Library patch mui/material-ui#36221

Closed

eps1lon added a commit to eps1lon/act-warning-mcve that referenced this pull request Feb 16, 2023

fix: No more "missing act" warning

312f3d7

Using testing-library/react-testing-library#1137

This was referenced Feb 16, 2023

fix: No more "missing act" warning trv-wcaneira/act-warning-mcve#1

Draft

fix: No more "missing act" warning eps1lon/missing-act-setstate-finally-repro#1

Draft

React 18. set state in finally throws "act" warning, though test is passing #1051

Closed

eps1lon linked an issue Feb 16, 2023 that may be closed by this pull request

React 18. set state in finally throws "act" warning, though test is passing #1051

Closed

eps1lon marked this pull request as ready for review February 16, 2023 17:05

eps1lon merged commit f78839b into testing-library:alpha Feb 16, 2023

eps1lon deleted the fix/nanotasks-troll branch February 16, 2023 22:46

This was referenced Feb 16, 2023

release: 14.0.0 #1178

Merged

post-upgrade, unexpected act warning with findBy queries (includes repro) #1125

Closed

Vinnl mentioned this pull request Feb 20, 2023

Bump @testing-library/react from 13.4.0 to 14.0.0 mozilla/fx-private-relay#3119

Closed

bpinto mentioned this pull request Feb 26, 2023

Update of the @testing-library/react version to 14.0.0 throws "act" warnings testing-library/user-event#1104

Closed

jsnajdr mentioned this pull request Mar 15, 2023

Flush all pending microtasks and updates before returning from waitFor callstack/react-native-testing-library#1366

Merged

jsnajdr reviewed Mar 18, 2023

View reviewed changes

wojtekmaj mentioned this pull request Mar 29, 2023

Update to v14 breaks @testing-library/user-event on Vitest #1197

Open

eps1lon mentioned this pull request May 22, 2023

test: Add test for flushing before exiting waitFor #1215

Merged

iumehara added a commit to iumehara/full-stack-tdd that referenced this pull request Jun 5, 2023

Update dependency '@testing-library/react' to 14.0.0, which fixes bug…

9f4ad64

… where act() warnings are displayed incorrectly testing-library/react-testing-library#1137

mgadewoll mentioned this pull request Apr 15, 2024

[Storybook] upgrade Storybook to v8 elastic/eui#7659

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Prevent "missing act" warning for queued microtasks #1137

fix: Prevent "missing act" warning for queued microtasks #1137

eps1lon commented Oct 8, 2022 •

edited

Loading

codesandbox-ci bot commented Oct 8, 2022 •

edited

Loading

codecov bot commented Oct 8, 2022 •

edited

Loading

MatanBobi left a comment

robin-drexler commented Nov 21, 2022

fastndead commented Dec 30, 2022

heath-pack commented Jan 25, 2023

diogoredin commented Feb 1, 2023

eps1lon commented Feb 15, 2023

jsnajdr Mar 18, 2023

eps1lon May 22, 2023

ak-beam commented Aug 10, 2023

MatanBobi commented Aug 13, 2023

fix: Prevent "missing act" warning for queued microtasks #1137

fix: Prevent "missing act" warning for queued microtasks #1137

Conversation

eps1lon commented Oct 8, 2022 • edited Loading

codesandbox-ci bot commented Oct 8, 2022 • edited Loading

codecov bot commented Oct 8, 2022 • edited Loading

Codecov Report

MatanBobi left a comment

Choose a reason for hiding this comment

robin-drexler commented Nov 21, 2022

fastndead commented Dec 30, 2022

heath-pack commented Jan 25, 2023

diogoredin commented Feb 1, 2023

eps1lon commented Feb 15, 2023

jsnajdr Mar 18, 2023

Choose a reason for hiding this comment

eps1lon May 22, 2023

Choose a reason for hiding this comment

ak-beam commented Aug 10, 2023

MatanBobi commented Aug 13, 2023

eps1lon commented Oct 8, 2022 •

edited

Loading

codesandbox-ci bot commented Oct 8, 2022 •

edited

Loading

codecov bot commented Oct 8, 2022 •

edited

Loading