-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect default import from @testing-library/dom #1162
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2334675:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
- Coverage 99.46% 99.46% -0.01%
==========================================
Files 92 89 -3
Lines 2070 2067 -3
Branches 704 701 -3
==========================================
- Hits 2059 2056 -3
Misses 11 11 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I will replace any other default export from |
@kentcdodds would you mind checking this whenever you have time? thanks! |
Thanks for the ping @yannbf! |
Thanks for the contribution @bryanjtc! |
🎉 This PR is included in version 14.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Fixes: #1160
Why:
@testing-library/dom
doesn’t have a default export.When trying to import and resolve a default export from
@testing-library/dom
the package would fail.How:
Removing the default export
Checklist: