Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): parse modifiers as characters #588

Merged
merged 1 commit into from
Mar 17, 2021
Merged

fix(keyboard): parse modifiers as characters #588

merged 1 commit into from
Mar 17, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Fix parsing modifiers as printable characters.

Why:

Closes #587

Checklist:

  • N/A Documentation
  • Tests
  • N/A Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #588 (6a343d4) into master (f251d15) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #588   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines          855       857    +2     
  Branches       323       325    +2     
=========================================
+ Hits           855       857    +2     
Impacted Files Coverage Δ
src/keyboard/getNextKeyDef.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f251d15...6a343d4. Read the comment docs.

@ph-fritsche ph-fritsche merged commit fa9299e into master Mar 17, 2021
@ph-fritsche ph-fritsche deleted the fix-587 branch March 17, 2021 11:53
@github-actions
Copy link

🎉 This PR is included in version 13.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SiebeVE
Copy link

SiebeVE commented Mar 17, 2021

I didn't know we got to travel at light speed yet! That was so fast I couldn't even say supercalifragilisticexpialidocious!

This was referenced Mar 17, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: modifiers as printable characters
2 participants