Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove legacy type features #702

Closed
nickserv opened this issue Jul 19, 2021 · 4 comments · Fixed by #780 or #783
Closed

Deprecate and remove legacy type features #702

nickserv opened this issue Jul 19, 2021 · 4 comments · Fixed by #780 or #783
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha
Milestone

Comments

@nickserv
Copy link
Member

The specialChars export and {} syntax for modifier keys from the old type implementation still exist, but are no longer necessary with the new implementation. Our plan for now is to mark features as deprecated in 13.x, and remove them in 14.0.0. We also might want to consolidate the two tables in the readme.

@nickserv nickserv added the BREAKING CHANGE This change will require a major version bump label Jul 19, 2021
@ph-fritsche
Copy link
Member

keyCode is already marked as deprecated and should be removed in v14 as well.

/** @deprecated use code instead */
keyCode:
keyDef.keyCode ??
// istanbul ignore next
(keyDef.key?.length === 1 ? keyDef.key.charCodeAt(0) : undefined),

(The implementation is also bugged - see #727 )

@github-actions
Copy link

🎉 This issue has been resolved in version 14.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 14.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ph-fritsche
Copy link
Member

Remaining keyboardState.carryValue is internal and can be removed in a refactor once behavior plugins for time and date input are rewritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha
Projects
None yet
2 participants