-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3.2 Extra peerDependencies vue-sfc-compiler required #261
Comments
hi @afontcu, |
Hi @ahnpnl! Just released VTL for Vue 3 on |
Thanks @afontcu , but I think there is still a mistake with this https://github.com/testing-library/vue-testing-library/blob/main/package.json#L48 it should be ^2.0.0 |
that being said, I'll happily take a PR updating the specified version to 2.0.0 😃 |
Describe the bug:
Starting from vue@3.2.13,
@vue/compiler-sfc
is built-in dependency in Vue.But removing it from dependencies list will cause package manager to warn about unmet dependency.
To Reproduce:
Install vue@next, then install testing library vue, sfc-complier is inside the dependency list if using npm 7+
Expected behavior
@vue/compiler-sfc
might be marked as optional if and only ifvue >= 3.2.13
, but I am afraid none of the existing package meta can handle this situation.The text was updated successfully, but these errors were encountered: