Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3.2 Extra peerDependencies vue-sfc-compiler required #261

Open
hikariNTU opened this issue Jan 21, 2022 · 4 comments
Open

Vue 3.2 Extra peerDependencies vue-sfc-compiler required #261

hikariNTU opened this issue Jan 21, 2022 · 4 comments

Comments

@hikariNTU
Copy link

Describe the bug:
Starting from vue@3.2.13, @vue/compiler-sfc is built-in dependency in Vue.
But removing it from dependencies list will cause package manager to warn about unmet dependency.

To Reproduce:
Install vue@next, then install testing library vue, sfc-complier is inside the dependency list if using npm 7+

Expected behavior
@vue/compiler-sfc might be marked as optional if and only if vue >= 3.2.13, but I am afraid none of the existing package meta can handle this situation.

@afontcu afontcu added the vue3 label Jan 21, 2022
@ahnpnl
Copy link
Contributor

ahnpnl commented Jun 7, 2022

hi @afontcu, @vue/test-utils has a release 2.0.0 on latest tag now, can we update this repo to use it instead of rc version?

@afontcu
Copy link
Member

afontcu commented Jun 8, 2022

Hi @ahnpnl! Just released VTL for Vue 3 on latest: https://www.npmjs.com/package/@testing-library/vue/v/6.6.0

@ahnpnl
Copy link
Contributor

ahnpnl commented Jun 8, 2022

Hi @ahnpnl! Just released VTL for Vue 3 on latest: https://www.npmjs.com/package/@testing-library/vue/v/6.6.0

Thanks @afontcu , but I think there is still a mistake with this https://github.com/testing-library/vue-testing-library/blob/main/package.json#L48 it should be ^2.0.0

@afontcu
Copy link
Member

afontcu commented Jun 8, 2022

I think there is still a mistake with this https://github.com/testing-library/vue-testing-library/blob/main/package.json#L48 it should be ^2.0.0

"^2.0.0-rc.18" should also accept installing 2.0.0:
image

that being said, I'll happily take a PR updating the specified version to 2.0.0 😃

@afontcu afontcu removed the vue3 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants