-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented initial version of schema validation #195 #196
feat: implemented initial version of schema validation #195 #196
Conversation
I made changes to the HttpParser that I'm insecure about. I needed to postpone sending a status and/or body in order to validate it. Need guidance to see if I don't break anything. |
Changes look good. Some modification suggestions in HttpParser:
First two instances (Line 91 and 169 can be removed), whereas 3rd instance can be modified from
|
Added docs. Can we merge it? |
* fix: move @types/js-yaml to dev deps * fix: upgrade convert-csv-to-json * deps: bump express to 4.18.1 * deps: bump fs-extra to latest * deps: bump logform * deps: bump moment * deps: bump node-cron * deps: bump pg * fix: pass grpc metadata to helpers. Closes #189 * fix: generic parsing of express requests to string * feat: implemented initial version of schema validation. Closes #195 (#196) * feat: implemented initial version of schema validation #195 * chore: tweaks after review #195 * doc: added a validation section in the docs #195 * doc: added a validation section in the docs #195 * fix/ignore lint errors Co-authored-by: Richard Ruiter <richard@inorm.nl>
🎉 This PR is included in version 0.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #195
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: