Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved handling of errors in response validation #201

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

richardruiter
Copy link
Collaborator

@richardruiter richardruiter commented Oct 26, 2022

Description

Please include a summary of the change and which issue is fixed.

Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • OS:
  • Node version:
  • NPM Version:

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • This does not break any existing functionalities
  • Any dependent changes have been merged and published in downstream modules

@shubhendumadhukar shubhendumadhukar merged commit 23622c5 into testinggospels:develop Oct 26, 2022
shubhendumadhukar added a commit that referenced this pull request Oct 29, 2022
* fix: async function broke delayed responses (#199)

* fix: reset delay after request

* fix: prevent validation from being a breaking change

* fix: improved handling of errors in response validation (#201)

* fix: async function broke delayed responses

* fix: improved handling of errors in response validation

* Remove demo link
@github-actions
Copy link

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants