Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transaction Gossip Disable Test #10

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

pcw109550
Copy link
Member

@pcw109550 pcw109550 commented Jun 16, 2023

This PR tests tx gossip disabling between two L2 execution clients. Requires #9.

Fixed op-erigon client's entrypoint.sh to disable tx gossiping by default. This is to follow op-geth's entrypoint.sh implementation.

op-geth:

EXTRA_FLAGS="--rollup.disabletxpoolgossip=true"

op-erigon(diff introduced in current PR):

if [ "$HIVE_OP_EXEC_DISABLE_TX_GOSSIP" != "" ]; then
    EXTRA_FLAGS="$EXTRA_FLAGS --rollup.disabletxpoolgossip=$HIVE_OP_EXEC_DISABLE_TX_GOSSIP"
else
    EXTRA_FLAGS="$EXTRA_FLAGS --rollup.disabletxpoolgossip=true"
fi

Example hive logs for new test:

created genesis files
added eth1 node 0 of type go-ethereum: 172.17.0.4
added op-l2 0: 172.17.0.5
added op-node 0: 172.17.0.6
added op-l2 1: 172.17.0.7
added op-node 1: 172.17.0.8
waiting for nodes to come up
peering execution clients 172.17.0.5 with 172.17.0.7
sent tx to verifier. Give some time to check tx gossiping is disabled
transaction not gossiped on sequencer
sent tx to sequencer. Give some time to check tx gossiping is disabled
transaction not gossiped on validator

Every test will fail on CI because --rollup.disabletxpoolgossip is not recognized because tx gossip disable implementation(testinprod-io/op-erigon#70) is not added in dockerhub docker image. Locally tested and works(l1ops, rpc, p2p). Will merge this PR after op-erigon remote docker image is updated.

@pcw109550 pcw109550 self-assigned this Jun 16, 2023
@pcw109550 pcw109550 requested a review from ImTei June 19, 2023 05:40
@pcw109550 pcw109550 force-pushed the pcw109550/tx-gossip-disable-test branch from 4571018 to 4702094 Compare June 19, 2023 09:51
@pcw109550 pcw109550 changed the base branch from pcw109550/tx-gossip-test to op-erigon June 27, 2023 03:02
@pcw109550 pcw109550 merged commit 7870100 into op-erigon Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants