Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider breaking to separate repos #28

Open
ChrisChinchilla opened this issue Nov 28, 2019 · 8 comments · Fixed by #30
Open

Consider breaking to separate repos #28

ChrisChinchilla opened this issue Nov 28, 2019 · 8 comments · Fixed by #30
Assignees

Comments

@ChrisChinchilla
Copy link
Contributor

While this isn't ideal for people finding the different styles (though this repo could be a guide to other styles instead), splitting into separate repos allows for the styles to support Vale server better, and for users to add individual styles as submodules to their projects.

@ChrisChinchilla ChrisChinchilla self-assigned this Nov 28, 2019
@dylan-k
Copy link

dylan-k commented Dec 20, 2019

@ChrisChinchilla I'm willing to assist with this if there's any good way to help?

@ChrisChinchilla
Copy link
Contributor Author

Thanks! @dylan-k ! It's relatively easy, I'll create the repos, and then assign some tasks to you? Then there'll be some post-tasks…

@dylan-k
Copy link

dylan-k commented Dec 27, 2019 via email

@ChrisChinchilla
Copy link
Contributor Author

@dylan-k
Copy link

dylan-k commented Jan 6, 2020

@ChrisChinchilla there may be an additional way for, as you said "people finding the different styles." Vale's creators maintain a collection of styles and have mentioned in the docs: "Have a style you'd like to see implemented? Let us know! We're actively looking to expand our library of pre-made, open-source styles."

The requirements for inclusion seem pretty straightforward. "All styles in this library must (1) be maintained in their own (dedicated) repository, (2) publish releases following Semantic Versioning, and (3) include a meta.json ..."

@ChrisChinchilla
Copy link
Contributor Author

Yup, exactly @dylan-k that's what we're working towards, and why we're separating them out first, then the next steps.

All styles in this library must (1) be maintained in their own (dedicated) repository

Being the first main requirement. I'll recap what we've both done and what still needs to be done asap, first week back at work…

@dylan-k
Copy link

dylan-k commented Feb 21, 2020

@ChrisChinchilla The styles you made repos for, a while ago, have all been moved over. Did you want to move any of the others as well?

@ChrisChinchilla
Copy link
Contributor Author

@dylan-k Yes I will, I get sporadic gaps of free time to work on things, I did all these during FOSSDEM ;)

I will also go through everything to create some tasks for the next steps, just testing the process with one or two repos first.

@ChrisChinchilla ChrisChinchilla added this to To do in Styles overhaul via automation Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants