Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests that execute envoytest.RunKill are flakey #154

Closed
codefromthecrypt opened this issue Mar 31, 2021 · 1 comment
Closed

tests that execute envoytest.RunKill are flakey #154

codefromthecrypt opened this issue Mar 31, 2021 · 1 comment

Comments

@codefromthecrypt
Copy link
Contributor

Tests that include lines like below can fail because they execute in the same directory

		err = envoytest.RunKill(r, filepath.Join("testdata", "null.yaml"), time.Second*10)
		require.NoError(t, err, "error from envoytest.RunKill")
    --- FAIL: Test_retrieveAdminAPIData/creates_all_non-empty_files (0.33s)
        admin_test.go:47: 
            	Error Trace:	admin_test.go:47
            	Error:      	Received unexpected error:
            	            	error killing runner: reading file in tar archive: file already exists: /home/circleci/.getenvoy/debug/1617156514287771521/certs.json
            	Test:       	Test_retrieveAdminAPIData/creates_all_non-empty_files
            	Messages:   	error from envoytest.RunKill
@codefromthecrypt
Copy link
Contributor Author

This is no longer broke as they don't execute in the same dir anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant