Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facet_wrap2 adding wrong x axis labels #140

Closed
manschmi2 opened this issue Jan 5, 2024 · 3 comments
Closed

facet_wrap2 adding wrong x axis labels #140

manschmi2 opened this issue Jan 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@manschmi2
Copy link

df <- data.frame(
xcat=c('A', 'A', 'C', 'A', 'B', 'C'),
yval=1:6,
facet=rep(c('y1', 'y2', 'y3'),2))

#works as intended
ggplot(df) +
geom_point(aes(x=xcat, y=yval)) +
facet_wrap2(~facet, ncol=3, scales='free_x')

#mis-labels facet y2
ggplot(df) +
geom_point(aes(x=xcat, y=yval)) +
facet_wrap2(~facet, ncol=2, scales='free_x')

@teunbrand teunbrand added the bug Something isn't working label Jan 23, 2024
@Close-your-eyes
Copy link

Close-your-eyes commented Jan 23, 2024

I noticed a similar thing. (Just in case another examples helps):


df <- tibble::tribble(
  ~sample,             ~pathogen,       ~n, ~detected_by_Illumina_app,
  "Exuberant Bovid",      "Yellow Cricket",    1599L,                      TRUE,
  "Prickly Jay",   "Cloudy Chimpanzee",     864L,                     FALSE,
  "Wandering Spider",     "Quarrelsome Fox",       6L,                     FALSE,
  "Giddy Nightingale",     "Aromatic Ocelot",       2L,                     FALSE,
  "Divergent Mastodon",   "Woebegone Crawdad",    4789L,                      TRUE,
  "Ad Vaquita",      "Yellow Cricket",     637L,                      TRUE,
  "Wandering Spider",         "Pricey Pony",       3L,                     FALSE,
  "Unwieldy Weasel",   "Cloudy Chimpanzee",       1L,                     FALSE,
  "Unequal Bee",   "Woebegone Crawdad",     588L,                      TRUE,
  "Overt Pony",      "Yellow Cricket",    2258L,                      TRUE,
  "Divergent Mastodon",       "Brawny Numbat",   13605L,                     FALSE,
  "Seemly Leopard",       "Physical Mite",    1767L,                      TRUE,
  "Kindly Snipe",         "Pricey Pony",       9L,                     FALSE,
  "Lowly Bovid", "Complete Salamander",     310L,                      TRUE,
  "Humorous Mastodon",      "Steadfast Mole",      84L,                      TRUE,
  "Unequal Bee",        "Spiky Dragon",     130L,                      TRUE,
  "Unwieldy Weasel",     "Decorous Muskox",    8234L,                     FALSE,
  "Perpetual Wolf",      "Steadfast Mole",      81L,                      TRUE,
  "Standing Basilisk",      "Yellow Cricket",     834L,                     FALSE,
  "Prickly Jay",          "Cagey Zebu",     169L,                      TRUE,
  "Pumped Ostrich",       "Brawny Numbat",      21L,                     FALSE,
  "Unequal Bee",      "Shocking Raven",       1L,                     FALSE,
  "Perpetual Wolf",     "Decorous Muskox",   44287L,                     FALSE,
  "Standing Basilisk",     "Quixotic Wombat",      52L,                     FALSE,
  "Annoying Kiwi",       "Brawny Numbat",     450L,                     FALSE,
  "Unwieldy Weasel",  "Dysfunctional Titi",       2L,                     FALSE,
  "Flowery Booby", "Complete Salamander",   17245L,                      TRUE,
  "Strange Cuckoo",      "Yellow Cricket",     236L,                      TRUE,
  "Exuberant Bovid",         "Misty Swift",       1L,                     FALSE,
  "Historical Minnow",     "Decorous Muskox", 2152963L,                      TRUE,
  "Stimulating Kangaroo",        "Spiky Dragon",       3L,                     FALSE,
  "Agonizing Raccoon",     "Decorous Muskox",   24953L,                     FALSE,
  "Scattered Caribou",      "Steadfast Mole",     194L,                      TRUE,
  "Seemly Leopard",     "Quixotic Wombat",      12L,                     FALSE,
  "Elegant Human",          "Cagey Zebu",       5L,                     FALSE,
  "Wild Egret",     "Quixotic Wombat",       1L,                     FALSE
)

ggplot(df, aes(x = sample, y = n)) +
  geom_col() +
  theme(axis.text.x = element_text(angle = 30, hjust = 1, vjust = 1), legend.title = element_text()) +
  ggh4x::facet_wrap2(vars(pathogen), scales = "free")

check the facet "Steadfast Mole" which has wrong x-axis labels.

ggplot(df, aes(x = sample, y = n)) +
  geom_col() +
  theme(axis.text.x = element_text(angle = 30, hjust = 1, vjust = 1), legend.title = element_text()) +
  facet_wrap(vars(pathogen), scales = "free")

@teunbrand
Copy link
Owner

Thanks both for reporting! I'll try to crank out a patch release sometime this week

@teunbrand
Copy link
Owner

Fixed by 53b923c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants