Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule): add textlint-rule-ja-space-around-link #22

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

0x6b
Copy link
Contributor

@0x6b 0x6b commented Feb 24, 2021

Quick hack based on your existing space-around-code package, as I have a use case which needs consistent spacing between Syntax.Link element.

I think someone have similar scenario so I made this as a pull request, but please feel free to discard this if you think it's not suited as one of rules of the preset. I can publish this as an independent textlint rule by myself. Thank you!

@azu
Copy link
Member

azu commented Feb 25, 2021

Thanks!

@azu azu merged commit 1d35645 into textlint-ja:master Feb 25, 2021
@azu
Copy link
Member

azu commented Feb 25, 2021

I just publish textlint-rule-ja-space-around-link

https://github.com/textlint-ja/textlint-rule-preset-ja-spacing/releases/tag/v2.1.0

We need to add space-around-link to presets.
I do not have opinion on this rule, so "ja-space-around-link" may be false by default.
https://github.com/textlint-ja/textlint-rule-preset-ja-spacing#%E3%83%87%E3%83%95%E3%82%A9%E3%83%AB%E3%83%88%E8%A8%AD%E5%AE%9A

@0x6b 0x6b deleted the space-around-link branch February 25, 2021 15:48
@0x6b
Copy link
Contributor Author

0x6b commented Mar 4, 2021

@azu Thank you for prompt action as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants