Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ja-nakaguro-or-halfwidth-space-between-katakana): replace match-index with String.prototype.matchAll #70

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix(ja-nakaguro-or-halfwidth-space-between-katakana): replace match-index with String.prototype.matchAll #70

merged 2 commits into from
Apr 26, 2024

Conversation

chick-p
Copy link
Contributor

@chick-p chick-p commented Apr 26, 2024

Replace match-index with String.prototype.matchAll.
Ref. #55

@azu azu added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Apr 26, 2024
@azu azu merged commit 648cb8e into textlint-ja:master Apr 26, 2024
2 checks passed
@azu
Copy link
Member

azu commented Apr 26, 2024

https://github.com/textlint-ja/textlint-rule-preset-ja-spacing/releases/tag/v2.4.3
Thanks!

@chick-p chick-p deleted the matchall-nakaguro-or-halfwidth-space branch April 26, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chick-p @azu