Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if stdin is a terminal use the cabal file in the cwd #100

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

if stdin is a terminal use the cabal file in the cwd #100

wants to merge 4 commits into from

Conversation

BebeSparkelSparkel
Copy link

@BebeSparkelSparkel BebeSparkelSparkel commented Jul 20, 2024 •
edited
Loading

closes #97

@tfausak tfausak added the enhancement New feature or request label Jul 25, 2024
tfausak
tfausak reviewed Jul 26, 2024
View reviewed changes
Copy link
Owner

@tfausak tfausak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! It would be nice to have a test for this new behavior.

source/library/CabalGild/Unstable/Main.hs Outdated Show resolved Hide resolved
source/library/CabalGild/Unstable/Main.hs Outdated Show resolved Hide resolved
source/library/CabalGild/Unstable/Main.hs Outdated Show resolved Hide resolved
@BebeSparkelSparkel
Copy link
Author

Looking good so far! It would be nice to have a test for this new behavior.

I don't write tests until things are looking good, so I'll fix the above issues and then add tests if you like what's been done.

@BebeSparkelSparkel
Copy link
Author

Added some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfausak tfausak tfausak left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to use cabal file in CWD
2 participants
@BebeSparkelSparkel @tfausak