plugin conflicting "Video Playback"

[thijsi123]

Hey, sorry for last time (forgot to close the issue😅)

I found out that the "Video playback" plugin conflicts with "restart on config changes"

Switching between video and song works normal but when I select next song/video the app restarts with different playlist.
Everything works great when I turn off "restart on config changes"

I added a gif with that shows the program restarting. (the pink is just a background nothing to do with yt music : ) )

I tried looking into it myself but I can't seem to fully understand how everything works since the only langue I can understand a bit is lua (zero to nothing of scripting experience) and don't know where the location of "restart on config changes" is.

[Araxeus]

I figured out why this bug happens:

the config is constantly updated by certain plugins, but always from renderer process
and since electron-store isn't watching the file (watch flag not enabled) but rather have some kind of hook on the change options functions inside the main process + look for changes on navigation or something like that - it then notice the changes on navigation and activate the function which restarts the app

for example even just changing the volume with precise-volume plugin and then navigating will cause a restart

TL:DR: config change callback wasn't activated immediately because config was changed from renderer process and the watch flag isn't enabled

@th-ch or anyone any thoughts on what should we do? enabling the watch flag causes the app to immediately restart instead of waiting for page navigation, but I don't think anyone wants the app constantly restarting.

Should the restart app on config change option be removed since lots of plugins saves data to it in real time?

[Araxeus]

I have created a PR that will fix this (#561)

Thank you for reporting this!

[thijsi123]

I have created a PR that will fix this (#561)

Thank you for reporting this!

It's nothing. Thank you for all the work : ).