Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPRIS is not registered anymore #872

Closed
dgalli1 opened this issue Nov 4, 2022 · 12 comments
Closed

MPRIS is not registered anymore #872

dgalli1 opened this issue Nov 4, 2022 · 12 comments
Labels
duplicate This issue or pull request already exists

Comments

@dgalli1
Copy link

dgalli1 commented Nov 4, 2022

In the newest Version the custom mpris controller doesn't seem to work anymore.
Which has the effect that Song Thumbnail will not be displayed on Linux anymore.

@aacebedo
Copy link

aacebedo commented Nov 10, 2022

I confirm. MPRIS not working on 1.18.0. Was working on 1.17.0
Wrong behavior can be seen using playerctl, player is found but an error about unsupported command is thrown.

@dgalli1
Copy link
Author

dgalli1 commented Nov 11, 2022

Issue probably lies in this unmaintained dependency:
dbusjs/node-dbus-next#111

@aacebedo
Copy link

Is this bug acknowledged? My distro package has been updated and mpris control is now broken :(

@aacebedo
Copy link

I solved the issue by deactivating the shortcuts

@dgalli1
Copy link
Author

dgalli1 commented Dec 16, 2022

It randomly started working again for me on arch linux 1.18.

Anyone still got this issue or can this be closed?

@aacebedo
Copy link

I don't think so. The artwork is not working and it means the shortcut functionality is not working completely.

@dgalli1
Copy link
Author

dgalli1 commented Dec 16, 2022

That's what I mean i could enable shortcuts again. And everything seems to work now for me. (electron19)

@Scridgeon
Copy link

I never had shortcuts enabled and MPRIS never worked. I'm using the 1.19 deb.

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 20, 2023

[dgalli1] Issue probably lies in this unmaintained dependency: dbusjs/node-dbus-next#111

to be fair, we are using mpris-service, which is a different package which is even more unmaintained:
https://github.com/dbusjs/mpris-service/blob/81665c48ec8912aee210407e60d4b3bc114894b3/package.json#L30

Even the dbus-next version there isn't the latest… 😂

Since I can't find any other dbus mpris implementations, the only solution that I can see would be to downgrade to electron<20
which isn't going to happen just for this

[Scridgeon] I never had shortcuts enabled and MPRIS never worked. I'm using the 1.19 deb.

Did you try enabling it?

@dgalli1
Copy link
Author

dgalli1 commented Jan 20, 2023

error time=1674255652.135471 sender=org.freedesktop.DBus -> destination=:1.139687 error_name=org.freedesktop.DBus.Error.ServiceUnknown reply_serial=15 string "The name org.mpris.MediaPlayer2.youtube-music was not provided by any .service files" method call time=1674255652.135501 sender=:1.139687 -> destination=org.freedesktop.DBus serial=16 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner string "org.mpris.MediaPlayer2.youtube-music" method return time=1674255652.135503 sender=org.freedesktop.DBus -> destination=:1.139687 serial=17 reply_serial=16 string ":1.129562" method call time=1674255652.135530 sender=:1.139687 -> destination=:1.129562 serial=17 path=/org/mpris/MediaPlayer2; interface=org.freedesktop.DBus.Properties; member=GetAll string "org.mpris.MediaPlayer2.Player" error time=1674255652.135894 sender=:1.129562 -> destination=:1.139687 error_name=com.github.dbus_next.ServiceError reply_serial=17 string "Service error: The service threw an error. TypeError: DBusError is not a constructor at PlayerInterface.LoopStatus (/usr/lib/youtube-music/app.asar/node_modules/mpris-service/src/interfaces/player.js:118:13) at handleGetAllProperties (/usr/lib/youtube-music/app.asar/node_modules/dbus-next/lib/service/handlers.js:125:22) at handleStdIfaces (/usr/lib/youtube-music/app.asar/node_modules/dbus-next/lib/service/handlers.js:240:7) at handleMessage (/usr/lib/youtube-music/app.asar/node_modules/dbus-next/lib/service/handlers.js:280:7) at handleMessage (/usr/lib/youtube-music/app.asar/node_modules/dbus-next/lib/bus.js:136:21) at EventEmitter.<anonymous> (/usr/lib/youtube-music/app.asar/node_modules/dbus-next/lib/bus.js:151:9) at EventEmitter.emit (node:events:527:28) at /usr/lib/youtube-music/app.asar/node_modules/dbus-next/lib/connection.js:116:14 at Socket.<anonymous> (/usr/lib/youtube-music/app.asar/node_modules/dbus-next/lib/message.js:63:9) at Socket.emit (node:events:527:28)" method call time=1674255652.135971 sender=:1.139687 -> destination=org.freedesktop.DBus serial=18 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch string "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0='org.mpris.MediaPlayer2.youtube-music'" method return time=1674255652.135973 sender=org.freedesktop.DBus -> destination=:1.139687 serial=18 reply_serial=18 signal time=1674255652.136115 sender=org.freedesktop.DBus -> destination=:1.139687 serial=247 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameLost string ":1.139687" signal time=1674255652.136118 sender=org.freedesktop.DBus -> destination=(null destination) serial=69779 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameOwnerChanged

It's really wierd with playerctl im getting this error but KDE seems to be able to control it without any issue. But yes issue is definitly in the dbus implementation.

btw somebody created a fork for newer node versions https://www.npmjs.com/package/@quadratclown/dbus-next

@amplexus
Copy link

I raised a dbusjs/mpris-service#52 to fix this. Tested locally (Ubuntu 22.10) with playerctl and youtube-music (built from source) and works for me.

See also #971

@JellyBrick JellyBrick added the bug Something isn't working label Oct 7, 2023
@JellyBrick
Copy link
Collaborator

Duplicate of #971

@JellyBrick JellyBrick marked this as a duplicate of #971 Oct 7, 2023
@JellyBrick JellyBrick reopened this Oct 7, 2023
@JellyBrick JellyBrick closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2023
@JellyBrick JellyBrick added duplicate This issue or pull request already exists and removed bug Something isn't working labels Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants