Metric bucket should not return error when error is expected #103
+118
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
do-not-return-error-when-expected
branch
from
c3f0d23 to
e780e80
Compare
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
do-not-return-error-when-expected
branch
from
e780e80 to
383edf7
Compare
objstore.go
Outdated
| b.metrics.opsFailures.WithLabelValues(op).Inc() | ||
| } | ||
| return err |
There was a problem hiding this comment.
We can omit this one no?
Suggested change
| return err |
There was a problem hiding this comment.
Thanks. Good catch!
Addressed in the latest commit
Signed-off-by: Ben Ye <benye@amazon.com>
fpetkovski
approved these changes
Dec 12, 2024
Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now, when metric bucket got an error which is
isOpFailureExpected, it doesn't increment the metric but still returns the error back to the caller.For example, it is quite common to log the error returned by bucket operations like below. However, even if I already specify
IsXXXErroras expected, the error still returns and will be logged. To filter it out, I need to add anotherIsXXXError(err)check to not log the error, which is very redundant to me.We also have another usecase which doesn't support checking the error in the caller. https://github.com/cortexproject/cortex/blob/master/pkg/storage/bucket/s3/bucket_client.go#L135
We implemented our own storage provider which has retries. Since the error is returned, there is no way for the retryer to know if the error is expected or not and it will keep retrying and finally log the error. There is no way to inject the expected error to the bucket client itself in this case.
Verification