From eaaeaa41626dd4e29f7d8b02dbefd4254ef7f397 Mon Sep 17 00:00:00 2001 From: yeya24 Date: Sat, 10 Aug 2019 01:14:24 +0800 Subject: [PATCH] unhide disable-downsampling flag in compactor (#1385) Signed-off-by: yeya24 --- cmd/thanos/compact.go | 7 +++---- docs/components/compact.md | 5 +++++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/cmd/thanos/compact.go b/cmd/thanos/compact.go index 09e55f3732..b7e3f01acb 100644 --- a/cmd/thanos/compact.go +++ b/cmd/thanos/compact.go @@ -99,10 +99,9 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application) { generateMissingIndexCacheFiles := cmd.Flag("index.generate-missing-cache-file", "If enabled, on startup compactor runs an on-off job that scans all the blocks to find all blocks with missing index cache file. It generates those if needed and upload."). Hidden().Default("false").Bool() - // TODO(bplotka): Remove this flag once https://github.com/thanos-io/thanos/issues/297 is fixed. - disableDownsampling := cmd.Flag("debug.disable-downsampling", "Disables downsampling. This is not recommended "+ - "as querying long time ranges without non-downsampled data is not efficient and not useful (is not possible to render all for human eye)."). - Hidden().Default("false").Bool() + disableDownsampling := cmd.Flag("downsampling.disable", "Disables downsampling. This is not recommended "+ + "as querying long time ranges without non-downsampled data is not efficient and useful e.g it is not possible to render all samples for a human eye anyway"). + Default("false").Bool() maxCompactionLevel := cmd.Flag("debug.max-compaction-level", fmt.Sprintf("Maximum compaction level, default is %d: %s", compactions.maxLevel(), compactions.String())). Hidden().Default(strconv.Itoa(compactions.maxLevel())).Int() diff --git a/docs/components/compact.md b/docs/components/compact.md index 06222a7e27..8b5917b30f 100644 --- a/docs/components/compact.md +++ b/docs/components/compact.md @@ -71,6 +71,11 @@ Flags: hour) in bucket. 0d - disables this retention -w, --wait Do not exit after all compactions have been processed and wait for new work. + --downsampling.disable Disables downsampling. This is not recommended as + querying long time ranges without non-downsampled + data is not efficient and useful e.g it is not + possible to render all samples for a human eye + anyway --block-sync-concurrency=20 Number of goroutines to use when syncing block metadata from object storage.