Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: UI doesn't persist Thanos-specific settings #1743

Closed
SuperQ opened this issue Nov 13, 2019 · 8 comments · Fixed by #1870
Closed

query: UI doesn't persist Thanos-specific settings #1743

SuperQ opened this issue Nov 13, 2019 · 8 comments · Fixed by #1870

Comments

@SuperQ
Copy link
Contributor

SuperQ commented Nov 13, 2019

When using the Thanos query UI, the additional settings like "deduplication", "partial response", etc are not persisted to the URL the same way settings like "stacked" are. This makes it difficult to share URLs.

Also problematic is that the UI defaults to "Only raw data", which can be expensive on large queries.

@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 13, 2019

It looks like this was at least partially fixed by #1463.

@FUSAKLA
Copy link
Member

FUSAKLA commented Nov 13, 2019

Agree this is annoying. Quickly looking at the UI it should be only:

  • deduplication
  • partial response

Regarding the default down sampling, would you suggest the automatic as a default?

@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 13, 2019

Yes, I think automatic should be the default.

@bwplotka
Copy link
Member

User can decide what is by default using query.auto-downsampling

In terms of URL settings, we added downsampling parameter: #1562 definitely this issue is valid to add all of them.

@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 13, 2019

@bwplotka That seems to only affect queries from things like Grafana. When you use the UI, it has separate defaults that aren't affected by the command line flag.

@bwplotka
Copy link
Member

Ah, good point, then I think either this flag should set this default, or we should have another. I think the former is preferable.

@obiesmans
Copy link
Contributor

@bwplotka : maybe a thanos-specific datasource for grafana could be a neat long-term solution ?

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants