Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Rename index cache YAML fields: type => backend, config => backend_config #2570

Closed
pstibrany opened this issue May 7, 2020 · 4 comments
Closed

TODO: Rename index cache YAML fields: type => backend, config => backend_config #2570

pstibrany opened this issue May 7, 2020 · 4 comments

Comments

@pstibrany
Copy link
Contributor

#2532 has introduced new cache config for caching bucket. In this PR, we use backend and backend_config YAML fields for selecting type of cache (memcached only for now), and its configuration.

This is different than what is used by index cache, where we use type and config. We would like to rename these to backend and backend_config as well at some point.
@pstibrany pstibrany mentioned this issue May 7, 2020
Merged
2 tasks
@pstibrany pstibrany changed the title TODO: Rename index cache YAML fields from type to backend and from config to backend_config TODO: Rename index cache YAML fields: type => backend, config => backend_config May 7, 2020
@ranjithkumar007
Copy link
Contributor

This is to be done after #2532 gets merged, right?
I would like to fix this if it's ok.

@pstibrany
Copy link
Contributor Author

This is to be done after #2532 gets merged, right?

Yes.

I would like to fix this if it's ok.

That would be great! Thanks.

@ranjithkumar007 ranjithkumar007 mentioned this issue May 7, 2020
Closed
2 tasks
@ranjithkumar007
Copy link
Contributor

ranjithkumar007 commented May 18, 2020 •
edited
Loading

We can close this now?

@kakkoyun
Copy link
Member

Closing as a result of the discussion on Slack https://cloud-native.slack.com/archives/CL25937SP/p1589816009201600.

Let us know if this is still desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename index cache YAML fields ranjithkumar007/thanos
3 participants
@kakkoyun @pstibrany @ranjithkumar007