compactor: 1h downsampling data is not continuous

[diemus]

Thanos, Prometheus and Golang version used:

thanos, version 0.17.0 (branch: HEAD, revision: 4899d9a3378c7dbd1f635f5271624cda8caec001)
  build user:       root@432c5bd5f94c
  build date:       20201118-17:38:06
  go version:       go1.15
  platform:         linux/amd64

Object Storage Provider:

S3 compatible service

What happened:
The data after downsampling to 1h is no longer continuous, the raw data and 5m downsampling does not have this problem.

there are parts of the data are continuous, it's not downsampling to 1h for now

What you expected to happen:

all downsampling data should be continuous

How to reproduce it (as minimally and precisely as possible):

Full logs to relevant components:

Anything else we need to know:

I see some warning logs about downsampling, and don't know why

level=warn ts=2021-01-10T08:30:09.927386011Z caller=streamed_block_writer.go:114 msg="empty chunks happened, skip series" series="{__name__='xxxxxx'}"
level=warn ts=2021-01-10T08:30:10.26568195Z caller=streamed_block_writer.go:114 msg="empty chunks happened, skip series" series="{__name__='xxxxxx'}"

[mveroone]

Hi.
I think it's similar to my problem which i was about to post :

Do you think it's the same problem ?

[qube222pl]

@mveroone take a look on my issue #3721
It looks exactly like your problem

[kakkoyun]

Hey @diemus, could you please share your compactor configuration? And also have you tried with the latest version of Thanos?

[diemus]

@kakkoyun no special configuration for compactor, I'm using 0.17.0, it's the latest version at that time

thanos compact 
--wait 
--compact.concurrency=5
--data-dir=/xxx/thanos-compact 
--objstore.config-file=/xxx/bucket.yml 
--retention.resolution-raw=30d 
--retention.resolution-5m=30d 
--retention.resolution-1h=30d

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗