Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded labels in store shard matcher #5625

Closed
fpetkovski opened this issue Aug 22, 2022 · 1 comment · Fixed by #5641
Closed

Remove hardcoded labels in store shard matcher #5625

fpetkovski opened this issue Aug 22, 2022 · 1 comment · Fixed by #5641
Labels
difficulty: easy dont-go-stale Label for important issues which tells the stalebot not to close them good first issue

Comments

@fpetkovski
Copy link
Contributor

Is your proposal related to a problem?

We currently hardcode certain labels in shard matchers because they should not be take account for sharding

// Exclude metric name and le label from sharding
if lbl.Name == "__name__" || lbl.Name == "le" {
continue
}

Describe the solution you'd like

We should completely remove the __name__ label as it should be okay to shard on it.
The le label should be propagated through the query analyzer instead. This will remove coupling on PromQL in Thanos Stores.

Additional context

Slack thread: https://cloud-native.slack.com/archives/CL25937SP/p1661110514624489

@fpetkovski fpetkovski added difficulty: easy good first issue dont-go-stale Label for important issues which tells the stalebot not to close them labels Aug 22, 2022
@haanhvu
Copy link
Contributor

haanhvu commented Aug 22, 2022

I'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy dont-go-stale Label for important issues which tells the stalebot not to close them good first issue
Projects
None yet
2 participants